Ravenbrook / Projects / Memory Pool System / Issues


MPS issue job001688

Title:AMC repeatedly allocates and initialises identical SegPrefs
Status:open
Priority:essential
Assigned user:Richard Brooksby
Organization:Ravenbrook
Description:AMC repeatedly allocates and innitialises identical SegPrefs

AMCBufferFill, which allocates segments for new buffers, allocates a
fresh SegPref every time. This is not necessary because for a given
generation the SegPref is always the same.

This is a problem because: it's a bit inefficient (though I doubt we
could measure it); the code gives the wrong impression (it gives the
impression that the SegPref might dynamically vary, which it doesn't,
by design).
Analysis:The SegPref can be allocated (and appropriately initialised) once, and
associated (for example, stored in) the PoolGen.
How found:unknown
Evidence:See poolamc.c AMCBufferFill
Observed in:1.108.0
Created by:David Jones
Created on:2007‑07‑20 16:29:15
Last modified by:Gareth Rees
Last modified on:2013‑03‑19 11:57:24
History:2007-07-20 DRJ Created.
2013-03-19 GDR Assigned to RB.

Generated at 2013-05-25 04:15:18 by $Id: //info.ravenbrook.com/infosys/cgi/issue.cgi#476 $

Copyright © Ravenbrook Limited. This document is provided "as is", without any express or implied warranty. In no event will the authors be held liable for any damages arising from the use of this document. You may not duplicate or reproduce this document in any form without the express permission of the copyright holder.

Ravenbrook / Projects / Memory Pool System / Issues