MPS issue job001737

TitleMPS: VMArena growth is brittle, does not fallback to smaller growth increment
Statusclosed
Priorityessential
Assigned userRichard Kistruck
OrganizationRavenbrook
DescriptionMPS: VMArena growth is brittle, does not fallback to smaller growth increment

RHSK 2007-12-19
See http://info.ravenbrook.com/mail/2007/12/19/12-17-36/0.txt
AnalysisRHSK 2007-12-19
Inspection of vmArenaExtend.
How foundunknown
EvidenceCustomer
Observed in1.108.0
Created byRichard Kistruck
Created on2007-12-19 18:03:49
Last modified byRichard Kistruck
Last modified on2007-12-21 17:12:23
History2007-12-19 RHSK Created.

Fixes

Change Effect Date User Description
163668 closed 2007-12-21 13:15:06 Richard Kistruck  MPS br/vmarenagrow: arenavm.c: VMChunkCreate() -- remove
 deliberately-failing test code.
163667 closed 2007-12-21 13:08:37 Richard Kistruck  MPS br/vmarenagrow: arenavm.c: vmArenaExtend() Tidy up code to
 choose chunk size, with a consistent, smaller (10%) .vmchunk.overhead
 estimate. Tidy diag and comments.
163665 closed 2007-12-20 18:00:50 Richard Kistruck  MPS br/vmarenagrow: arenavm.c: vmArenaExtend() will:
   a) choose a better chunkSize;
   b) fallback to smaller sizes if request fails.
 *** WARNING ***
 VMChunkCreate() has test-code that deliberately fails requests,
 for testing this functionality.
163664 open 2007-12-20 17:23:26 Richard Kistruck  MPS br/vmarenagrow: amcss.c: mps_arena_create /4 => too-small
 arena, to test arena growth. Also, make testArenaSIZE a round
 number (2^20 not 10^3*2^10).
163663 open 2007-12-20 17:16:43 Richard Kistruck MPS br/vmarenagrow: arena.c: ArenaDescribe() now reports total arena
reserved and committed (only the two most important things to know!).
Transgression: This entails calling the ArenaReserved function.