MPS issue job003319

TitleMVT creation takes "integer percentage" argument
Assigned userRichard Brooksby
DescriptionWhen you call mps_pool_create for an MVT or MVFF pool, you have to pass the argument "mps_count_t fragmentation_limit" which is documented to be "a percentage in (0, 100] that can be used to set an upper limit on the space overhead of MVT in case block death times and allocations do not correlate well."

It seems like poor design to use an integer percentage for a proportion when a floating-point number could have been used instead. Also, it's inconsistent with mps_gen_param_s, where a double is used for the mps_mortality proportion.
AnalysisReplace fragmentation_limit with a double, at least in the interface.

I've now fixed this for the new keyword arguments interface, but just by fixing the interface, rather than reworking the pool class code.
How foundinspection
Evidence[1] <>
Observed in1.110.0
Created byGareth Rees
Created on2012-10-17 18:08:42
Last modified byRichard Brooksby
Last modified on2013-05-16 13:57:19
History2012-10-17 GDR created.
2013-05-16 RB explained fix


Change Effect Date User Description
181862 closed 2013-05-16 13:54:06 Richard Brooksby The fragmentation limit argument to the MVT pool class is now passed as a floating point fraction, not a percentage, in the keyword interface.

Imported from Git
 Author: Richard Brooksby <> 1368708846 +0100
 Committer: Richard Brooksby <> 1368708846 +0100
 sha1: fce7a658a291032c734af083a25b95a3e090bc13