MPS issue job003711

TitleCompiling windows.h takes a long time
Statusclosed
Prioritynice
Assigned userGareth Rees
OrganizationRavenbrook
DescriptionBruce Mitchener [1] suggests that we "Define WIN32_LEAN_AND_MEAN when including windows.h."
AnalysisWIN32_LEAN_AND_MEAN is documented at [2]. Defining it exposes a bug in lockutw3.c [3], which calls malloc() without including <malloc.h>.
How foundcustomer
Evidence[1] <https://github.com/Ravenbrook/mps-temporary/pull/3>
[2] <http://support.microsoft.com/kb/166474>
[3] <https://github.com/Ravenbrook/mps-temporary/pull/3#issuecomment-20561810>
Created byGareth Rees
Created on2014-03-22 20:09:31
Last modified byGareth Rees
Last modified on2014-03-24 20:38:10
History2014-03-22 GDR Created.

Fixes

Change Effect Date User Description
184979 closed 2014-03-24 18:49:22 Gareth Rees Ensure that windows.h is only included via mpswin.h, so that we always have the same set of definitions and pragmas in effect.
Turn on WIN32_LEAN_AND_MEAN when including windows.h to improve compilation time.