| Title | Root modes not in sync |
| Status | closed |
| Priority | nice |
| Assigned user | Gareth Rees |
| Organization | Ravenbrook |
| Description | The comment in mps.h [1] says: /* .rm: Keep in sync with <code/mpmtypes.h#rm> */ but there are two modes in mps.h (CONST and PROT) and three modes in mpmtypes.h (CONSTANT, PROTECTABLE, PROTECTABLE_INNER). Previously discovered by RIT [3]. |
| Analysis | Add PROT_INNER to mps.h? Or remove PROTECTABLE_INNER from mpmtypes.h? A comment in RootModeCheck [2] says "RootModePROTECTABLE_INNER implies RootModePROTECTABLE" but that seem wrong because RootModePROTECTABLE adds behavior to RootModePROTECTABLE_INNER, not vice versa. |
| How found | inspection |
| Evidence | [1] <http://www.ravenbrook.com/project/mps/master/code/mpmtypes.h>[2] < http://www.ravenbrook.com/project/mps/master/code/root.c>[3] < https://info.ravenbrook.com/project/mps/mail/1997/12/18/12-06/0.txt> |
| Created by | Gareth Rees |
| Created on | 2014-04-06 18:29:59 |
| Last modified by | Gareth Rees |
| Last modified on | 2014-10-14 22:59:32 |
| History | 2014-04-06 GDR Created. |
| Change | Effect | Date | User | Description |
|---|---|---|---|---|
| 187271 | closed | 2014-10-14 22:59:32 | Gareth Rees | Add constant MPS_RM_PROT_INNER and document it. |