MPS issue job003836

TitlePageRetStruct is obsolete
Assigned userGareth Rees
DescriptionIn poolamc.c, there's a PageRetStruct which is used to accumulate statistics about pages condemned, reclaimed and retained. This is unused, untested and obsolete (it talks about "pages" when it should talk about "arena grains" [1]).
AnalysisThis structure was added by Richard Kistruck in change 168562 [2] when he was trying to improve collection speed in the presence of large objects (job002205). The same information could better be collected via the telemetry system, by adding AMCWhiten and AMCReclaim events.
How foundinspection
Evidence[1] <>
[2] <>
Created byGareth Rees
Created on2014-06-13 15:13:25
Last modified byGareth Rees
Last modified on2014-10-14 23:05:56
History2014-06-13 GDR Created.


Change Effect Date User Description
187274 closed 2014-10-14 23:05:56 Gareth Rees AMC no longer keeps statistics about pages condemned and retained. If we need this kind of analysis, it would be better to add more telemetry until we can do the analysis offline.