| Title | Can't set MPS_KEY_SPARE |
| Status | closed |
| Priority | essential |
| Assigned user | Gareth Rees |
| Organization | Ravenbrook |
| Description | If you try to set MPS_KEY_SPARE for an MVFF pool as described in the manual [1]: MPS_ARGS_ADD(args, MPS_KEY_SPARE, 0.75); Then the compilation fails with: apss.c:169:5: error: expected identifier MPS_ARGS_ADD(args, MPS_KEY_SPARE, 0.75); |
| Analysis | This is because mps.h says #define MPS_KEY_SPARE_FIELD double when it should say #define MPS_KEY_SPARE_FIELD d The mistake was made in change 184498 [2]. The error would have been caught immediately if the feature had been tested, but the absence of a test case wasn't spotted when the feature was merged to the master sources. |
| How found | automated_test |
| Evidence | [1] http://www.ravenbrook.com/project/mps/...al/html/pool/mvff.html#c.mps_class_mvff[2] https://info.ravenbrook.com/infosys/cgi/perfbrowse.cgi?%40describe+184498 |
| Test procedure | apss |
| Created by | Gareth Rees |
| Created on | 2014-10-10 11:56:41 |
| Last modified by | Gareth Rees |
| Last modified on | 2014-10-20 17:19:33 |
| History | 2014-10-10 GDR Created. |
| Change | Effect | Date | User | Description |
|---|---|---|---|---|
| 187174 | closed | 2014-10-10 12:05:23 | Gareth Rees | Fix the definition of MPS_KEY_SPARE_FIELD so that you can set this keyword argument when creating an MVFF pool. Add test cases that use this feature. |