MPS issue job004101

TitlePlain CBS doesn't work
Assigned userGareth Rees
DescriptionThe CBS module provides three Land classes: CBS, CBSFast and CBSZoned. The first of these does not work: when it creates the splay tree it passes SplayTrivUpdate for the update function (see cbsInit) but then in cbsBlockAlloc it calls SplayNodeInit which asserts SplayHasUpdate(splay).

Note also that this was not found by any test case because landtest.c only tests CBSFast.
AnalysisThe assertion seems incorrect -- cbsBlockAlloc is the only place where SplayNodeInit is called.
How foundmanual_test
Created byGareth Rees
Created on2018-07-30 21:37:21
Last modified byGareth Rees
Last modified on2018-07-31 09:38:13
History2018-07-30 GDR Created.


Change Effect Date User Description
194807 closed 2018-07-31 09:38:13 Gareth Rees Don't assert SplayHasUpdate(splay) -- otherwise plain CBS does not work.
landtest now exercises CBS and CBSZoned as well as CBSFast.
Delete fbmtest (superseded by landtest).