P4DTI issue job000597

TitleTest suite doesn't give error for invalid Bugzilla admin user
Assigned userNick Barnes
DescriptionOn swan (RedHat 7.3, Bugzilla), set the bugzilla_admin_user in config_swan.py to an incorrect user. For example:
bugzilla_admin_user = 'spurious@ravenbrook.com'
Then run the emailsuffix test in test_p4dti.py (using "python test_p4dti.py emailsuffix.runTest") and you get this misleading error message:
ERROR: Bugzilla 'emailsuffix' parameter (test_p4dti.emailsuffix)
Traceback (innermost last):
  File "test_p4dti.py", line 2957, in runTest
  File "test_p4dti.py", line 1204, in check_startup
  File "/home/fai/p4/project/p4dti/master/test/../code/replicator/replicator.py", line 869, in prepare_to_run
  File "/home/fai/p4/project/p4dti/master/test/../code/replicator/replicator.py", line 1008, in mail_startup_message
    unmatches = self.config.user_translator.unmatched_users(
  File "/home/fai/p4/project/p4dti/master/test/../code/replicator/dt_bugzilla.py", line 1290, in unmatched_users
    self.init_users(bz, p4)
  File "/home/fai/p4/project/p4dti/master/test/../code/replicator/dt_bugzilla.py", line 1280, in init_users
    raise error, catalog.msg(513, self.bugzilla_user)
Bugzilla module error: (P4DTI-5139) Bugzilla P4DTI user 'nb+p4dti-replicator0@ravenbrook.com' is not a known Bugzilla user.
The actual error is that the test has failed to set the Bugzilla parameter emailsuffix. This failure is because the admin user/password combination are wrong, and the error should occur at that stage.
AnalysisFAI Some other sections of test_p4dti do report the correct error message, displaying the HTML error which is returned from running the Bugzilla CGI script.
How foundautomated_test
EvidenceSet an invalid bugzilla_admin_user and run test_p4dti.py.
Test procedure<http://www.ravenbrook.com/project/p4dti/master/test/test_p4dti.py>, section 20
Created byFrancis Irving
Created on2002-10-08 13:28:33
Last modified byNick Barnes
Last modified on2018-07-05 17:28:04
History2002-10-08 FAI Created.
2010-10-06 GDR Assigned to NB since user FAI no longer works on the project.
       2018-07-05 NB Suspended because the P4DTI is obsolete.