Ravenbrook / Projects / Memory Pool System / Issues

Memory Pool System


MPS issue job001545

Title: MPS hot varieties do no AVERs or other checking
Status: closed
Priority: critical
Assigned user: Richard Kistruck
Product: mps
Organization: Ravenbrook
Description: MPS hot varieties do no AVERs or other checking.

Related jobs:

See 2006-12-13 footnote to job000534: the conversion in config.h
from old varieties to the new build feature set was wrong for
hot varieties.

See also job001546: MPS hot varieties gather tuning statistics


[RHSK 2006-12-13]
Hot varieties do not #define ASSERT, so CHECK (now renamed AVER_AND_CHECK) is never defined, so all AVERs and checks compile to nothing. Hot varieties do correctly set a minimal CHECK_DEFAULT (now renamed CHECKLEVEL_INITIAL), but that has no effect on its own.

Also, hot varieties #define DEBUG, and therefore gather statistics; this is presumably a mistake.
Analysis: [RHSK 2006-12-13]
Source inspection during job001248.
How found: unknown
Evidence: Source.
Observed in: 1.106.2
Introduced in: 1.100.0
Test procedure: none
Created by: Richard Kistruck
Created on: 2006-12-13 15:26:51
Last modified by: Richard Kistruck
Last modified on: 2006-12-13 16:18:01
History: 2006-12-13 RHSK Created.

Fixes

Change Effect Date User Description
161213 closed 2006-12-13 16:01:46 Richard Kistruck MPS make hot varieties do AVERs and checks, and *not* gather statistics.
job001545 & job001546
161211 open 2006-12-13 15:41:53 Richard Kistruck MPS config.h: make it easy to see which variety turns on which features.
The logic is now clear, but wrong. See job001545.
(Source-only change).

Generated at 2008-09-06 23:22:27 by $Id: //info.ravenbrook.com/infosys/cgi/issue.cgi#430 $

Copyright © Ravenbrook Limited. This document is provided "as is", without any express or implied warranty. In no event will the authors be held liable for any damages arising from the use of this document. You may not duplicate or reproduce this document in any form without the express permission of the copyright holder.

Ravenbrook / Projects / Memory Pool System / Issues