P4DTI issue job000240

TitlePerforce server can crash if P4DTI is started with existing jobs
Assigned userGareth Rees
DescriptionThe Perforce server can crash if the P4DTI is started for the first time when there are existing jobs.
This shouldn't ever happen, because the P4DTI checks for existing jobs before adding its fields to the jobspec. (That's why the priority is low.)
AnalysisThe reason for this appears to be that field P4DTI-filespecs has disposition "default", but no default value (see evidence). So we could fix the defect by adding a default value.
This corresponds to Perforce job 4797 and Perforce job 4959.
How foundcustomer
Observed in0.4.2
Introduced in0.4.0
Test procedure<http://www.ravenbrook.com/project/p4dti/master/test/test_p4dti.py>, section 7
Created byGareth Rees
Created on2001-03-01 16:28:34
Last modified byGareth Rees
Last modified on2001-12-10 19:29:18
History2001-03-01 GDR Created.


Change Effect Date User Description
9879 closed 2001-03-13 12:25:33 Gareth Rees Gave P4DTI-filespecs field in the Perforce jobspec the disposition 'optional' rather than 'default', so that Perforce doesn't complain about it not having a Preset.
Removed recording of conflicts; conflict resolution always happens immediately. In particular, deleted the 'action' field in Bugzilla, the 'P4DTI_ACTION' field in TeamTrack, the 'P4DTI-action' field in Perforce, and all code and design dealing with these fields. None of this code was being used anyway, so the main effect is to significantly simplify the replication algorithm.