P4DTI issue job000298

TitleMultiple Perforce sections in the Bugzilla form
Assigned userNick Barnes
DescriptionA user who upgrades from one version of the P4DTI to another but omits to remove their old Bugzilla patch may find that the new Bugzilla patch applies and they get two Perforce sections in the bug form and two p4dti Bugzilla parameters.
We tell people to remove the old patch in the readme.txt, but this is easy to miss. Removing the old patch currently requires the old patch file, and users may have deleted this before being ready to apply the new patch. In particular, Linux RPM users will remove the old RPM before installing the new RPM, and removing the old RPM will remove the old patch file.
This is less severe with Bugzilla 2.16 or later, because the patch creates a file and so reapplying the patch will fail, instead of simply complaining.
AnalysisCould do our own patch removal by suitably marking the code which we add to Bugzilla and writing a small script to remove it. Otherwise this is a hard problem. We can't do it in the RPM scripts because they don't know where Bugzilla is installed. We could ship all the old patch files with the new release, along with a script which will identify which patch (if any) has already been applied and remove it before installing the new patch. This could work as we are unlikely to have very many versions of the patch (currently there are two).
GDR 2001-07-17: In fact the patches change quite frequently, so this isn't as good as it looks at first sight. We could include in the patch a Perl comment that identifies the P4DTI release. This would make it a bit easier.
Need to fix upgrade instructions in the readme.txt.
How foundcustomer
Evidence<URL: http://info.ravenbrook.com/mail/2001/04/17/08-34-36/0.txt>
Observed in1.1.1
Introduced in0.4.0
Created byNick Barnes
Created on2001-04-17 13:04:15
Last modified byNick Barnes
Last modified on2018-07-05 17:27:35
History2001-04-17 NB Created.
2001-07-19 GDR Added support information and fixed title, description.
2003-08-12 NB Updated to reflect change in patch style for Bugzilla 2.16.
       2018-07-05 NB Suspended because the P4DTI is obsolete.

Advice for all releases.

Workaround 1: Restore original copies of bug_form.pl and defparams.pl from the appropriate Bugzilla distribution. Then apply the patch for your release of Bugzilla and the P4DTI. (But don't do this if you've customized these files.)

Workaround 2: If you have customized these files, then you need to back out both patches with patch -R < patch-file and restore the one you need. You probably need to get the old patch file by downloading the old P4DTI release again.


Change Effect Date User Description
14299 open 2001-07-19 11:46:58 Gareth Rees Remove Bugzilla patch when upgrading.