P4DTI issue job000429

TitleError message in conflict e-mail might be wrong
Assigned userGareth Rees
DescriptionWhen the P4DTI sends out an e-mail explaining that a job and issue have been edited simultaneously and that it's overwritten the job with the issue, it might include an incorrect error message.
AnalysisThe mail_report() method decides whether to include an error message by looking at sys.exc_info. But when mail_report is called in the case of a conflict, there hasn't been an error, so mail_report just picks up the previous error, if there was one.
We could solve this by clearing the error at some point (is that possible?) or by indicating to mail_report whether we think there's been an error; or we could raise a suitable error even if all that's happened is a conflict (but then there would be a bogus traceback).
How foundautomated_test
EvidenceFound while running lifecycle test case.
Observed in1.3.3
Introduced in1.3.0
Test procedure<http://www.ravenbrook.com/project/p4dti/master/test/test_p4dti.py>, section 10.6
Created byGareth Rees
Created on2001-12-07 19:16:34
Last modified byGareth Rees
Last modified on2001-12-10 20:01:00
History2001-12-07 GDR Created.


Change Effect Date User Description
24953 closed 2001-12-08 01:18:08 Gareth Rees Don't include an error message and stack traceback in an ordinary conflict report.