P4DTI issue job000628

TitleBugzilla 2.16 and 2.16.1 patches are broken
Statusclosed
Prioritycritical
Assigned userNick Barnes
OrganizationRavenbrook
DescriptionThe patches provided with P4DTI 1.5.0 for Bugzilla 2.16 and 2.16.1 are broken. Using the Bugzilla bug form with these patches results in a "Software error" message in the Bugzilla user interface, complaining about global symbols "$rid" and "$sid":
Software error:

Global symbol "$rid" requires explicit package name at bug_form.pl line 120.
Global symbol "$rid" requires explicit package name at bug_form.pl line 121.
Global symbol "$sid" requires explicit package name at bug_form.pl line 122.
Global symbol "$sid" requires explicit package name at bug_form.pl line 123.
Compilation failed in require at /var/www/html/nb/bugzilla-2.16.1/post_bug.cgi line 31.
AnalysisThis is a result of an incorrect fix to job000615. The same change was applied to all the bug_form.pl files, but the 2.16.* bug_form needs to be different because of the templatisation changes in 2.16.*.
How foundcustomer
EvidenceI just know.
Observed in1.5.0
Introduced in1.5.0
Created byNick Barnes
Created on2002-11-19 17:02:00
Last modified byNick Barnes
Last modified on2002-11-19 17:13:38
History2002-11-19 NB Created.

Fixes

Change Effect Date User Description
35732 closed 2002-11-19 17:13:20 Nick Barnes Bugzilla 2.16.x is templatised, so this code is different, so applying the same fix for job000618 was wrong.