P4DTI issue job000694

Titlecheck_jobs doesn't work on Windows if .py file association is set
Statusclosed
Priorityessential
Assigned userNick Barnes
OrganizationRavenbrook
DescriptionIf the .py file association is set on Windows (so typing "p4" runs Python on p4.py), then running the check_jobs.py script in the P4DTI install directory fails with a misleading error message:
Perforce error: (P4DTI-7054) The command 'p4 -V' didn't report a recognizable version number. Check your setting for the 'p4_client_executable' parameter.
Analysischeck_jobs.py fails under Windows when run from the P4DTI install directory because of Windows filetype mapping. The check_jobs.py script uses the Python P4 module without specifying a Perforce client executable, so the P4 module runs a command "p4", which Windows interprets to mean "run the p4.py script in Python".
Modify

def check_jobs():
    p4i = p4.p4(port = config.p4_port,
                user = config.p4_user,
                password = config.p4_password)

to

def check_jobs():
    p4i = p4.p4(port = config.p4_port,
                client_executable = config.p4_client_executable,
                user = config.p4_user,
                password = config.p4_password)

This is Perforce job 009794.[1]
How foundcustomer
Evidence[1] <http://info.ravenbrook.com/mail/2002/11/27/18-42-01/0.txt>
Observed in1.5.3
Introduced in1.3.0
Created byNick Barnes
Created on2003-05-16 15:50:24
Last modified byNick Barnes
Last modified on2003-05-23 16:55:50
History2003-05-16 NB Created.

Fixes

Change Effect Date User Description
46168 closed 2003-05-23 16:55:40 Nick Barnes check_jobs.py needs to pass the client_executable argument into the p4 module.